Conversation
well core information behave test development
Refactored Group model in db/group.py, adding the `group_type` and `monitoring_frequency` fields. Added new categories and terms to core/lexicon.json to support expanded group types and monitoring frequencies.
… StatusHistory table. `well_status` is defined as a lexicon category, but it should be a lexicon value associated with the `status_type` category. The `status_type` category does not exist, but it should. The terms assigned to the `well_status` category should actually be assigned to the `status_value` category. Renamed `well_status` category to `status_value`. Added new `status_type` category and related terms. Updated term definitions.
`Monitoring Status` should be a value/term associated with the `status_type` category, not a category unto itself. Removed the `monitoring_status` category and associated terms. Expanded terms associated with the `monitoring_frequency` category.
`group_type` and `monitoring_frequency` fields should be lexicon terms. Updated `group_type` and `monitoring_frequency` fields to map to lexicon terms.
…re-well-info-models-schemas BDMS-221-225: Core well information model updates
…s-to-pass-tests source tests for bdms 221
…er-updates BDMS 221: updates to transfer scripts
jacob-a-brown
requested review from
TylerAdamMartinez,
chasetmartin,
jirhiker,
kbighorse and
ksmuczynski
Codecov Report❌ Patch coverage is
|
| elevation_method: ElevationMethod | None = None | ||
| coordinate_accuracy: float | None = None | ||
| coordinate_method: CoordinateMethod | None = None | ||
| # elevation_accuracy: float | None = None |
Contributor
There was a problem hiding this comment.
Why not delete these fields if they're not going to be used?
Contributor
Author
There was a problem hiding this comment.
I decided to comment them out for now because we may want to include them in the future, so they're here for notes. I can remove those comments if it's bad style to keep these in.
jirhiker
approved these changes
Nov 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
well-core-information.featurewas written, requiring updates throughout the repositoryHow
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?
WellData.MonitoringStatusis currently being used to transfer both monitoring status and frequency from NM_Aquifer, but this field has not been maintained. Once we receive a table Ethan made in May the transfer script will need to be updated again.current_locationfor athingis in the form of a GeoJSON, should all location responses be in the same GeoJSON format? It may be a good idea to have this be the standard, rather than have aLocationResponsethat is different from theLocationGeoJSONResponse. (For example: thecurrent_locationin theThingResponseuses a GeoJSON, whereas the response for/locationuses theLocationResponse.